Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress CA1860 when in expression tree #7123

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

CollinAlpert
Copy link
Contributor

Fixes #7063

@CollinAlpert CollinAlpert requested a review from a team as a code owner January 2, 2024 10:20
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94955fd) 96.43% compared to head (750d338) 96.44%.
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7123      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +0.01%     
==========================================
  Files        1412     1411       -1     
  Lines      336968   337282     +314     
  Branches    11143    11156      +13     
==========================================
+ Hits       324946   325295     +349     
+ Misses       9218     9183      -35     
  Partials     2804     2804              

{
}
}
""";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 The indentation here would be vastly improved if the closing """ was indented exactly 4 spaces relative to const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

@mavasani mavasani merged commit f27a83e into dotnet:main Jan 9, 2024
11 checks passed
@CollinAlpert CollinAlpert deleted the issue-7063 branch January 9, 2024 09:12
@ArturDorochowicz
Copy link

ArturDorochowicz commented Mar 15, 2024

@mavasani When is it going to be released? Before .net 9? Thank you.

@CollinAlpert
Copy link
Contributor Author

@ArturDorochowicz You can reference this package version to get the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow us to configure CA1860 so that it does not apply to expression trees
4 participants