-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect editorconfig var preference in CA1854 #6023
Conversation
e9da5c3
to
8ce8f17
Compare
Codecov Report
@@ Coverage Diff @@
## main #6023 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 1338 1338
Lines 307108 307164 +56
Branches 9785 9787 +2
=======================================
+ Hits 294917 294974 +57
+ Misses 9814 9812 -2
- Partials 2377 2378 +1 |
var model = await context.Document.GetSemanticModelAsync(context.CancellationToken).ConfigureAwait(false); | ||
if (model.GetTypeInfo(dictionaryAccess).Type is not { } type) | ||
{ | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the type is always available, probably should use var
if it is not
Thanks @Youssef1313, looks good to me except it is not covered the variable name duplication part of #6022, could you cover that with this PR? We can still merge this PR without that and leave the issue open for that part |
I'll take a look at the duplication issue later. The fix will likely be using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Youssef1313!
Part of #6022