Do not report on awaitable-awaiter patterns #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Dec 30, 2020
| { | ||
| return false; | ||
| } | ||
|
|
||
| // CA1000 says one shouldn't declare static members on generic types. So don't flag such cases. | ||
| if (methodSymbol.ContainingType.IsGenericType && methodSymbol.IsExternallyVisible()) | ||
| if (methodSymbol.IsExternallyVisible()) |
There was a problem hiding this comment.
Avoid doing this check twice.
Codecov Report
@@ Coverage Diff @@
## master #4639 +/- ##
==========================================
- Coverage 95.77% 95.77% -0.01%
==========================================
Files 1193 1193
Lines 269067 269233 +166
Branches 16245 16267 +22
==========================================
+ Hits 257706 257858 +152
+ Misses 9278 9277 -1
- Partials 2083 2098 +15 |
mavasani
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4623
There is a first commit meant to ensure all code related to skipping the analysis is contained in the
ShouldAnalyzemethod instead of being in multiple place. I suggest to review it first.