Fixed compiler errors in Desktop.Analyzers.UnitTests (#1005)

dotnet · May 18, 2016 · 19d67c8 · 19d67c8
1 parent 3410300
commit 19d67c8
Show file tree

Hide file tree

Showing 30 changed files with 254 additions and 175 deletions.
diff --git a/src/Desktop.Analyzers/UnitTests/DoNotUseInsecureCryptographicAlgorithmsTests.cs b/src/Desktop.Analyzers/UnitTests/DoNotUseInsecureCryptographicAlgorithmsTests.cs
@@ -152,6 +152,7 @@ private async Task TestMethod()
 
             VerifyBasic(@"
 Imports System.Security.Cryptography
+Imports System.Threading.Tasks
 
 Module TestClass
     Public Async Sub TestMethod()
@@ -160,7 +161,7 @@ Return New HMACMD5()
                        End Function)
     End Sub
 End Module",
-            GetBasicResultAt(7, 35, s_CA5351Rule, "TestMethod", "HMACMD5"));
+            GetBasicResultAt(8, 35, s_CA5351Rule, "Run", "HMACMD5"));
         }
 
         [Fact]
@@ -296,7 +297,7 @@ Imports System.Security.Cryptography
 Imports System.Threading.Tasks
 Namespace TestNamespace
 	Class TestClass
-		Private Function TestMethod() As Task
+		Private Async Function TestMethod() As Task
 			Await Task.Run(Function() 
 			DES.Create()
 End Function)
@@ -518,6 +519,7 @@ End Class
 End Namespace",
 //Test1
                 @"
+Imports System
 Imports System.Security.Cryptography
 Namespace TestNamespace
 	Class MyDES
@@ -727,6 +729,7 @@ End Class
 End Namespace",
 //Test1
 @"
+Imports System
 Imports System.Security.Cryptography
 Namespace TestNamespace
 	Class MyRC2
@@ -1068,6 +1071,7 @@ End Class
 
 //Test1
                 @"
+Imports System
 Imports System.Security.Cryptography
 
 Namespace TestNamespace
@@ -1523,6 +1527,8 @@ End Class
 End Namespace",
 //Test1
                 @"
+Imports System
+Imports System.Security
 Imports System.Security.Cryptography
 Namespace TestNamespace
 	Class MyRIPEMD160
@@ -1601,6 +1607,7 @@ End Class
 End Namespace",
 //Test1
                 @"
+Imports System
 Imports System.Security.Cryptography
 Namespace TestNamespace
 	Class MyRIPEMD160
@@ -1880,6 +1887,7 @@ End Class
 End Namespace",
 //Test1
                 @"
+Imports System
 Imports System.Security.Cryptography
 
 Namespace TestNamespace
@@ -2099,6 +2107,7 @@ End Class
 End Namespace",
 //Test1
                 @"
+Imports System
 Imports System.Security.Cryptography
 Namespace TestNamespace
 	Class MyRijndael

diff --git a/.../UnitTests/DoNotUseInsecureDTDProcessingCreateUsingInsecureInputXmlReaderSettingsTests.cs b/.../UnitTests/DoNotUseInsecureDTDProcessingCreateUsingInsecureInputXmlReaderSettingsTests.cs
@@ -228,6 +228,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass6a
@@ -242,7 +243,7 @@ Catch generatedExceptionName As Exception
         End Try
     End Sub
 End Class",
-                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(9, 26)
+                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(10, 26)
             );
         }
 
@@ -271,6 +272,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass6a
@@ -284,7 +286,7 @@ Catch generatedExceptionName As Exception
         End Try
     End Sub
 End Class",
-                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(10, 26)
+                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(11, 26)
             );
         }
 
@@ -313,6 +315,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass6a
@@ -327,7 +330,7 @@ Catch generatedExceptionName As Exception
         End Try
     End Sub
 End Class",
-                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(12, 26)
+                GetCA3075XmlReaderCreateInsecureInputBasicResultAt(13, 26)
             );
         }
 
@@ -372,7 +375,7 @@ Await Task.Run(Function()
 End Function)
     End Function
 
-    Private Sub TestMethod2()
+    Private Async Sub TestMethod2()
         Await TestMethod()
     End Sub
 End Class",
@@ -542,6 +545,7 @@ public static string TestMethod(string inputRule)
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.IO
 Imports System.Xml
 
@@ -578,7 +582,7 @@ Return outputRule
         End Function
     End Class
 End Namespace",
-                GetCA3075XmlDocumentWithNoSecureResolverBasicResultAt(10, 31)
+                GetCA3075XmlDocumentWithNoSecureResolverBasicResultAt(11, 31)
             );
         }
     }

diff --git a/src/Desktop.Analyzers/UnitTests/DoNotUseInsecureDTDProcessingDoNotUseLoadXmlTests.cs b/src/Desktop.Analyzers/UnitTests/DoNotUseInsecureDTDProcessingDoNotUseLoadXmlTests.cs
@@ -185,6 +185,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -201,7 +202,7 @@ Catch generatedExceptionName As Exception
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(11, 13)
+                GetCA3075LoadXmlBasicResultAt(12, 13)
             );
         }
 
@@ -230,6 +231,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -245,7 +247,7 @@ Dim doc As New XmlDocument() With { _
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(12, 13)
+                GetCA3075LoadXmlBasicResultAt(13, 13)
             );
         }
 
@@ -274,6 +276,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -290,7 +293,7 @@ Dim doc As New XmlDocument() With { _
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(14, 13)
+                GetCA3075LoadXmlBasicResultAt(15, 13)
             );
         }
 
@@ -336,7 +339,7 @@ Dim doc As New XmlDocument() With { _
 End Function)
     End Function
 
-    Private Sub TestMethod2()
+    Private Async Sub TestMethod2()
         Await TestMethod()
     End Sub
 End Class",
@@ -458,6 +461,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -474,7 +478,7 @@ Catch generatedExceptionName As Exception
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(11, 13)
+                GetCA3075LoadXmlBasicResultAt(12, 13)
             );
         }
 
@@ -503,6 +507,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -518,7 +523,7 @@ Dim doc As New XmlDataDocument() With { _
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(12, 13)
+                GetCA3075LoadXmlBasicResultAt(13, 13)
             );
         }
 
@@ -547,6 +552,7 @@ private void TestMethod()
             );
 
             VerifyBasic(@"
+Imports System
 Imports System.Xml
 
 Class TestClass
@@ -563,7 +569,7 @@ Dim doc As New XmlDataDocument() With { _
         End Try
     End Sub
 End Class",
-                GetCA3075LoadXmlBasicResultAt(14, 13)
+                GetCA3075LoadXmlBasicResultAt(15, 13)
             );
         }
 
@@ -609,7 +615,7 @@ Dim doc As New XmlDataDocument() With { _
 End Function)
     End Function
 
-    Private Sub TestMethod2()
+    Private Async Sub TestMethod2()
         Await TestMethod()
     End Sub
 End Class",
@@ -659,7 +665,7 @@ Dim doc As New XmlDataDocument() With { _
 End Function)
     End Function
 
-    Private Sub TestMethod2()
+    Private Async Sub TestMethod2()
         Await TestMethod()
     End Sub
 End Class",