Merge pull request #3424 from mavasani/Issue3414

Handle null base type in CA1710
dotnet · Mar 24, 2020 · 01850a4 · 01850a4
2 parents 6dc3658 + 62ca6c9
commit 01850a4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldHaveCorrectSuffix.cs b/...Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldHaveCorrectSuffix.cs
@@ -127,7 +127,7 @@ private static void AnalyzeCompilationStart(CompilationStartAnalysisContext cont
                 Debug.Assert(namedTypeSymbol.MatchesConfiguredVisibility(saContext.Options, SpecialCollectionRule, saContext.CancellationToken));
 
                 var baseTypes = excludeIndirectBaseTypes
-                    ? (new[] { namedTypeSymbol.BaseType })
+                    ? namedTypeSymbol.BaseType != null ? ImmutableArray.Create(namedTypeSymbol.BaseType) : ImmutableArray<INamedTypeSymbol>.Empty
                     : namedTypeSymbol.GetBaseTypes();
 
                 if (TryGetTypeSuffix(baseTypes, baseTypeSuffixMap, userTypeSuffixMap, out var typeSuffixInfo))

diff --git a/...soft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldHaveCorrectSuffixTests.cs b/...soft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldHaveCorrectSuffixTests.cs
@@ -1855,6 +1855,15 @@ End Class"
             await vbTest.RunAsync();
         }
 
+        [Fact, WorkItem(3414, "https://github.com/dotnet/roslyn-analyzers/issues/3414")]
+        public async Task CA1710_Interfaces()
+        {
+            await VerifyCS.VerifyAnalyzerAsync(@"
+public interface I
+{
+}");
+        }
+
         private static DiagnosticResult GetCA1710BasicResultAt(int line, int column, string typeName, string suffix, bool isSpecial = false) =>
             VerifyVB.Diagnostic(isSpecial ? IdentifiersShouldHaveCorrectSuffixAnalyzer.SpecialCollectionRule : IdentifiersShouldHaveCorrectSuffixAnalyzer.DefaultRule)
                 .WithLocation(line, column)