Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for detecting CI environments and setting ContinuousIntegrationBuild #49

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

MattKotsenas
Copy link
Member

This adds test coverage so that we can merge #11 / #12.

@@ -20,7 +21,9 @@ public static ProjectCreator ReproducibleBuildProject(this ProjectCreatorTemplat
.Import(Path.Combine(ThisAssemblyDirectory, "DotNet.ReproducibleBuilds.targets"))
.Save();

ProjectCollection projectCollection = new(); // Create a new collection for each project to ensure environment variables aren't shared between tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle detail, good catch

@baronfel baronfel requested a review from a team as a code owner August 30, 2024 01:39
@baronfel baronfel merged commit 4336d59 into dotnet:main Aug 30, 2024
3 checks passed
@MattKotsenas MattKotsenas deleted the refactor/ci-property-tests branch August 30, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants