Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisableImplicitLibraryPacksFolder #21

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Add DisableImplicitLibraryPacksFolder #21

merged 3 commits into from
Sep 8, 2022

Conversation

cmeeren
Copy link

@cmeeren cmeeren commented Aug 19, 2022

As requested by @baronfel in dotnet/fsharp#13678 (comment)

I'm not 100% certain about the wording, but based on comparisons with the implementation of DisableImplicitNuGetFallbackFolder I think it's correct.

It is my desire that this should be released fairly quickly. Let me know if that is not possible or desirable, and I will then add DisableImplicitLibraryPacksFolder manually to all of my own projects in the meantime.

Copy link

@bddckr bddckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a small update to link to the new file from the TOC as well.

@cmeeren
Copy link
Author

cmeeren commented Aug 19, 2022

Done

@baronfel
Copy link
Member

baronfel commented Sep 8, 2022

Sorry for the delay here - I'll merge this now.

@baronfel baronfel merged commit 6c69594 into dotnet:main Sep 8, 2022
@cmeeren cmeeren deleted the add-DisableImplicitLibraryPacksFolder branch September 12, 2022 08:42
@cmeeren
Copy link
Author

cmeeren commented Sep 21, 2022

Wonderful! 🎉 Will it be released sometime soon?

@cmeeren
Copy link
Author

cmeeren commented Oct 4, 2022

Hi! Could this be released to NuGet?

@baronfel
Copy link
Member

baronfel commented Oct 6, 2022

Hi! Taking a look at this now - it's my first time releasing this package since I became a maintainer. Hope to have it out soon.

@baronfel baronfel added the enhancement New feature or request label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants