Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid computing tag helper documentation strings in compiler #8706

Merged
merged 10 commits into from
May 16, 2023
Merged

Avoid computing tag helper documentation strings in compiler #8706

merged 10 commits into from
May 16, 2023

Commits on May 15, 2023

  1. Introduce documetnation objects for tag helpers 

    Rather than just storing documentation strings, tag helpers objects
store a "documentation object". This can be a string as before, or it
can a DocumentationDescriptor object that can provide the
documentation text. This has been done in a non-breaking way.
    @DustinCampbell
    DustinCampbell committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bc33795 View commit details
    Browse the repository at this point in the history

  2. Update compiler to use tag helper documentation objects 

    The compiler no longer sets the Documentation property of any tag
helper objects that it creates. Instead, it specifies particular
DocumentationDescriptors. This avoids formatting strings in the
compiler that it doesn't actually use.
    @DustinCampbell
    DustinCampbell committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7c2e7ad View commit details
    Browse the repository at this point in the history

  3. Update tooling JSON.NET converters to handle documentation objects

    @DustinCampbell
    DustinCampbell committed May 15, 2023
    Configuration menu
    Copy the full SHA
    5b43408 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Unify code that switches on documentation object type

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    08b5202 View commit details
    Browse the repository at this point in the history

  2. Clean up pattern matching in FormattedDescriptor

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    297ca30 View commit details
    Browse the repository at this point in the history

  3. Add explanatory comments and remove DocumentationDescriptor.Format(...)

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9fb9385 View commit details
    Browse the repository at this point in the history

  4. Add Debug.Fail(...) to catch future problems

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    5aae02d View commit details
    Browse the repository at this point in the history

  5. Validate 'id' parameter of DocumentationDescriptor.From(...)

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4d8751c View commit details
    Browse the repository at this point in the history

  6. Simplify SimpleDescriptor.ComputeHashCode()

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    64bd02d View commit details
    Browse the repository at this point in the history

  7. Update Assumed.Unreachable() to include file/line info

    @DustinCampbell
    DustinCampbell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    95ab8ad View commit details
    Browse the repository at this point in the history