Fixing completion commit chars #10533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to (and shouldn't) specify AllCommitCharacters in capabilities for our completion endpoint. Doing so causes them to always be added to all completion items. Since we are using our completion endoint for VSCode now, it was causing undesirable behavior there. VSCode HTML doesn't use ">" as the commit character, and having it specified in server capabilities was causing us to always use ":", ">", " ", and "=" as the commit characters for all items. See microsoft/vscode#217772
davidwengier
approved these changes
Jun 25, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
We don't need to (and shouldn't) specify AllCommitCharacters in capabilities for our completion endpoint. Doing so causes them to always be added to all completion items.
Since we are using our completion endoint for VSCode now, it was causing undesirable behavior there. VSCode HTML doesn't use ">" as the commit character, and having it specified in server capabilities was causing us to always use ":", ">", " ", and "=" as the commit characters for all items.
Fixes:
microsoft/vscode#217772