Update binding redirect for System.Reflection.Metadata to match referenced assembly version #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enced assembly version Update the binding redirect for System.Reflection.Metadata to match the referenced version of the assembly from the current package reference. When this is out of date, it causes a lot of pain in consuming repos (in particular in dotnet/sdk and dotnet/runtime). It might be worth some tooling to ensure that this stays up to date.
|
Also update Line 33 in e1716a1 eng/Packages.props.
|
|
Updating this requires updating VS, which is a pain. Let's continue discussing in the linked issue why this appears to be necessary and what else we can do about it. |
|
I was only updating this as the layout for desktop MSBuild was resolving 6.0.1 from somewhere, and I thought it was coming from MSBuild itself. I'll take a closer look and circle back with a more in-depth summary if what I've found. |
|
I've handled this with dotnet/sdk@ We can revisit this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the binding redirect for System.Reflection.Metadata to match the referenced version of the assembly from the current package reference.
When this is out of date, it causes a lot of pain in consuming repos (in particular in dotnet/sdk and dotnet/runtime). It might be worth some tooling to ensure that this stays up to date.
See dotnet/sdk#27149 for some context.
cc: @rainersigwald