-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Including pending fixes from Xamarin.Forms SRs #8702
Conversation
@@ -413,6 +413,7 @@ void HandlePropertyChanged(object sender, PropertyChangedEventArgs e) | |||
e.PropertyName == NavigationPage.BarBackgroundProperty.PropertyName) | |||
{ | |||
UpdateBarBackground(); | |||
UpdateHideNavigationBarSeparator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | ||
if (Background != null) | ||
{ | ||
Background.Parent = this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -439,12 +439,35 @@ void HandleRadioButtonGroupSelectionChanged(RadioButton selected, RadioButtonGro | |||
|
|||
void HandleRadioButtonGroupValueChanged(Element layout, RadioButtonGroupValueChanged args) | |||
{ | |||
if (IsChecked || string.IsNullOrEmpty(GroupName) || GroupName != args.GroupName || !object.Equals(Value, args.Value) || !MatchesScope(args)) | |||
if (IsChecked || string.IsNullOrEmpty(GroupName) || GroupName != args.GroupName || !MatchesScope(args)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs
Outdated
Show resolved
Hide resolved
@@ -156,12 +156,20 @@ void OnStarted(object? sender, EventArgs eventArgs) | |||
|
|||
void OnEnded(object? sender, EventArgs eventArgs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs
Outdated
Show resolved
Hide resolved
@@ -57,6 +57,12 @@ protected UITableViewRowAnimation ReloadSectionsAnimation | |||
set { _dataSource.ReloadSectionsAnimation = value; } | |||
} | |||
|
|||
[Internals.Preserve(Conditional = true)] | |||
public ListViewRenderer(IntPtr handle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could fix this exception #7799
From @PureWeen
|
To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later. |
Description of Change
Including pending fixes from Xamarin.Forms SRs.
xamarin/Xamarin.Forms#15330
xamarin/Xamarin.Forms#15299
xamarin/Xamarin.Forms#15291
xamarin/Xamarin.Forms#15369
xamarin/Xamarin.Forms#1497