Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Including pending fixes from Xamarin.Forms SRs #8702

Closed
wants to merge 9 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jul 13, 2022

@@ -413,6 +413,7 @@ void HandlePropertyChanged(object sender, PropertyChangedEventArgs e)
e.PropertyName == NavigationPage.BarBackgroundProperty.PropertyName)
{
UpdateBarBackground();
UpdateHideNavigationBarSeparator();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
if (Background != null)
{
Background.Parent = this;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -439,12 +439,35 @@ void HandleRadioButtonGroupSelectionChanged(RadioButton selected, RadioButtonGro

void HandleRadioButtonGroupValueChanged(Element layout, RadioButtonGroupValueChanged args)
{
if (IsChecked || string.IsNullOrEmpty(GroupName) || GroupName != args.GroupName || !object.Equals(Value, args.Value) || !MatchesScope(args))
if (IsChecked || string.IsNullOrEmpty(GroupName) || GroupName != args.GroupName || !MatchesScope(args))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -156,12 +156,20 @@ void OnStarted(object? sender, EventArgs eventArgs)

void OnEnded(object? sender, EventArgs eventArgs)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -57,6 +57,12 @@ protected UITableViewRowAnimation ReloadSectionsAnimation
set { _dataSource.ReloadSectionsAnimation = value; }
}

[Internals.Preserve(Conditional = true)]
public ListViewRenderer(IntPtr handle)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could fix this exception #7799

@mattleibow
Copy link
Member

From @PureWeen

Some of those fixes don't feel like they'd apply to MAUI

  • like dispatching setting the parent to null
  • the focus change on editors
  • Adding the ctor on ListViewRenderer

I feel like we'd want to get maui issues/repros put together for some of those to make sure they are still applicable and then fix with tests individually for SR if they are SR important

@mattleibow mattleibow marked this pull request as draft October 5, 2022 15:55
@mattleibow mattleibow added the do-not-merge Don't merge this PR label Oct 5, 2022
@jsuarezruiz
Copy link
Contributor Author

To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later.

@jsuarezruiz jsuarezruiz closed this Nov 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants