Fix firing modal from appearing ios14 #14240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
NavigationRenderer depends on
ViewDidAppear
getting called fromParentingViewController
. If you push modals too early in the life cycle thenViewDidAppear
is never called so the initial Navigation from loading the first page was never resolving. This wasn't an issue on shell because with shell all navigation passes through a single pipeline and that pipeline makes sure nav request don't overlap.