Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments/refactoring for clarification (#14176) #14217

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Mar 27, 2023

Description of Change

Refactoring and clarification of #14176

@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@hartez hartez enabled auto-merge (squash) March 27, 2023 15:45
@rmarinho rmarinho self-requested a review March 27, 2023 15:48
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Mar 27, 2023
@hartez hartez merged commit e12299c into main Mar 27, 2023
@hartez hartez deleted the fix-orientation-3 branch March 27, 2023 17:01
@rmarinho
Copy link
Member

/backport to release/8.0.1xx-preview3

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview3: https://github.com/dotnet/maui/actions/runs/4545744100

@github-actions
Copy link
Contributor

@rmarinho backporting to release/8.0.1xx-preview3 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Comments/refactoring for clarification
.git/rebase-apply/patch:40: trailing whitespace.
				
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
CONFLICT (content): Merge conflict in src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Comments/refactoring for clarification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@rmarinho an error occurred while backporting to release/8.0.1xx-preview3, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants