Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)" #13874

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

rachelkang
Copy link
Member

This reverts commit 20f54bc, reversing changes made to a775a2d.

Description of Change

Rollback #12890 from main until failing tests are figured out :/

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 13, 2023
@PureWeen PureWeen enabled auto-merge March 13, 2023 17:01
@rmarinho
Copy link
Member

@mandel-macaque seems we need something on the action to escape " on the commit json of Notify release branch action

@PureWeen PureWeen changed the title Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)" Show keyboard on Android entry/editor/searchbar focus - revert 12890 Mar 13, 2023
@PureWeen PureWeen changed the title Show keyboard on Android entry/editor/searchbar focus - revert 12890 Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)" Mar 13, 2023
@rmarinho
Copy link
Member

@mandel-macaque should we. run this action just on main, net8 and release/* branches?

@PureWeen PureWeen disabled auto-merge March 13, 2023 18:23
@mandel-macaque
Copy link
Member

@rmarinho should always be ran, but we can add the required ignore, I'll do that in a diff PR as with the " escape.

@mandel-macaque
Copy link
Member

@PureWeen PureWeen merged commit d49140c into main Mar 14, 2023
@PureWeen PureWeen deleted the rollback-12890 branch March 14, 2023 01:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants