Bump WASDK and BuildTools #13687
Merged
Bump WASDK and BuildTools #13687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-infrastructure
mandel-macaque
approved these changes
Mar 6, 2023
|
The build is green because CI has VS installed and there are some "known path lookups" happening to find the tools in the VS install. |
mattleibow
commented
Mar 15, 2023
| @@ -24,6 +24,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup Condition="$(TargetFramework.Contains('-windows'))"> | |||
| <PackageReference Include="Microsoft.WindowsAppSDK" /> | |||
| <PackageReference Include="Microsoft.Windows.SDK.BuildTools" /> | |||
There was a problem hiding this comment.
We can remove this line once WASDK updates to depend on the newer version - or we may just keep this so we control the base version.
mattleibow
changed the title
mattleibow
added
dependencies
jfversluis
approved these changes
Mar 20, 2023
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates the WASDK and also the BuildTools. We no longer need the BuildTools reference in the project as we can depend on it ourselves and the new buildTransitive feature will automatically add it to the apps.
Issues Fixed
Fixes an issue when users update the build of the WSDK, the BuildTools get a bad version and also need to be updated.