[Android] Fix bidirectional scrolling on Android #13623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
approved these changes
Mar 1, 2023
Eilon
added
the
area-layout
samhouts
approved these changes
Mar 2, 2023
|
Could we include a sample in the Gallery?. Maybe in the actual sample include a Picker allowing to change the |
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
|
@jsuarezruiz I added a gallery example on #13657 . I will also see if I can add device tests tomorrow |
hartez
approved these changes
Mar 8, 2023
Eilon
removed
the
area-layout
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On android , we use 2 native scrollviews to handle bidirectional scrolling. The HorizontalScrollView was always laying on the available height, but we want the vertical scroll to work on it's parent we need to use the scrollview content height and not the default available height
Issues Fixed
Fixes #2768
Fixes #5759
Fixes #7811
Fixes #9000
Related to #7979 android part only
Related to #13187 android part only