Ensure an exact measure for the nested horizontal scrollview #13554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
mattleibow
reviewed
Mar 21, 2023
| @@ -2,6 +2,7 @@ | |||
| using Android.Animation; | |||
| using Android.Content; | |||
| using Android.Graphics; | |||
| using Android.Hardware.Lights; | |||
There was a problem hiding this comment.
this happens to me sometimes, is VS is adding this without us noticing ?
| @@ -301,6 +310,7 @@ protected MauiHorizontalScrollView(IntPtr javaReference, JniHandleOwnership tran | |||
| public MauiHorizontalScrollView(Context? context, MauiScrollView parentScrollView) : base(context) | |||
| { | |||
| _parentScrollView = parentScrollView; | |||
| Tag = "Microsoft.Maui.Android.HorizontalScrollView"; | |||
There was a problem hiding this comment.
Looks like its for the tests: https://github.com/dotnet/maui/pull/13554/files#diff-e047a3b468635cce7361a6c1bef5be0c7b6a8cce9f8662d737577ea66e34a844R115
(Line 115 in the test below)
jfversluis
approved these changes
Mar 21, 2023
rmarinho
approved these changes
Mar 21, 2023
Eilon
added
area-controls-scrollview
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The MauiScrollView knows what height the nested HorizontalScrollView should be, but the default measurement system just sees it as vertical ScrollView content and measures it with MeasureSpecMode.Unspecified. Which means that it only gets a MeasuredHeight as tall as the content, despite the fact that it may be laid out at a greater height.
We can fix this by adding a MeasureSpecMode.Exactly measure at the target height right before laying out the HorizontalScrollView.
Marking this as a draft right now, it needs device tests. Plus, we could probably check the MeasuredHeight/Width of the HorizontalScrollView before doing the exact measure to determine if we really need the extra measure call (we don't need it unless the measured size is less than the target layout size).
Issues Fixed
Fixes #13498