[Windows] Fix Picker alignment issues #13516
Conversation
jsuarezruiz
added
t/bug
| @@ -7,6 +7,9 @@ public partial class Picker | |||
| { | |||
| #if IOS | |||
| [PlatformConfiguration.iOSSpecific.Picker.UpdateModeProperty.PropertyName] = MapUpdateMode, | |||
| #elif WINDOWS | |||
| [nameof(Picker.HorizontalOptions)] = MapHorizontalOptions, | |||
There was a problem hiding this comment.
It is a Draft because I am reviewing why this is necessary in the case of the Picker in Windows.
src/Controls/samples/Controls.Sample/Pages/Controls/PickerPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/Controls/samples/Controls.Sample/Pages/Controls/PickerPage.xaml.cs
Outdated
Show resolved
Hide resolved
….xaml.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
|
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines. |
|
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines. |
|
The same issue seems to apply to DatePicker and TimePicker |
|
Setting HorizontalOptions on a Picker doesn't make it FillandExpand - it just stays the normal size it is - the Issue #6391 has been marked as Closed due to this commit - so there is no MAUI issue to follow for updates. Am I missing something? EDIT - I just noticed the 8.0.0 pre-release tag in it - which is part of .NET 8 which isn;t released until Nov and is too unstable too upgrade to just now - seems a bit unfair to Close down issues if they are not available on a stable version of MAUI :( |
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Description of Change
Fix Windows Picker alignment issues.
To validate the changes can use the added Picker sample to the .NET MAUI Gallery o the added device tests.
Issues Fixed
Fixes #6391