Fix timing on iOS Toolbar #12888
Merged
Fix timing on iOS Toolbar #12888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix_ios_toolbar_quirks_take_2
branch
from
e18e3ac
to
2e7ff60
Compare
|
@rmarinho I tested this on a 13.7 and a 14.5 iPhone Let me know if I should test back further from that. |
PureWeen
commented
Jan 24, 2023
| //Pre iOS 15 | ||
| item = item ?? uINavigationBar.FindDescendantView<UIView>(result => | ||
| { | ||
| return result.Class.Name?.Contains("UINavigationBarContentView", StringComparison.OrdinalIgnoreCase) == true; |
There was a problem hiding this comment.
@rmarinho here's the update that fixes for iOS13/14
rmarinho
requested changes
Jan 26, 2023
This reverts commit 5abffde. # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
PureWeen
force-pushed
the
fix_ios_toolbar_quirks_take_2
branch
from
e27ee5a
to
4eb2219
Compare
rmarinho
approved these changes
Jan 26, 2023
hartez
added
backport/suggested
PureWeen
removed
the
backport/NO
|
Adding this one back into the pool for some discussion. This one fixes a bunch of issues and I think we can break apart a few parts of this one. For example, I think just backporting the xplat changes here will fix a number of issues |
|
When will these changes be available? |
hartez
added
the
backport/NO
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With MAUI we moved the code for processing
Toolbarlogic up into the xplat layer by way of an xplatToolbarcontrol. This allowed us to consolidate the toolbar logic that was copy and pasted across all platforms and between shell and non-shell. On iOS the shell toolbar management is handled byShellPageToolbarTrackerwhich gets instantiated for every single page. The code inside that tracker needs to ignore anytoolbarupdates if it's not the currently visible page.iOS is also a little bit tricky to wire up with regards to timing the back button title text. The BackButton text is based on the
UIViewController.NavigationItemof the previous page so we have to pull theBackButtonBehavioroff the incoming page and set it on theNavItemof the previous page before the current page is visible.NavigationPagegets around this by making it so the user has to setNavigationPage.BackButtonTitleon the previous page.NavigationPagebasically replicates howiOSpropagates back button text where asShelllets you set the back button text on the currently visible page.Issues Fixed
Fixes #10945
Fixes #11691
Fixes #9269
Fixes #9842
Fixes #9687
Fixes #8335
Fixed #10452