-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timing on iOS Toolbar #12363
Merged
Merged
Fix timing on iOS Toolbar #12363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
area-controls-shell
Shell Navigation, Routes, Tabs, Flyout
area/toolbar
labels
Jan 4, 2023
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
force-pushed
the
fix_ios_toolbar_quirks
branch
from
January 6, 2023 20:10
3579544
to
e42d629
Compare
rachelkang
reviewed
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!! Just had a couple questions and nitpick edits, but overall lgtm :)
src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.iOS.cs
Outdated
Show resolved
Hide resolved
rachelkang
reviewed
Jan 18, 2023
PureWeen
force-pushed
the
fix_ios_toolbar_quirks
branch
from
January 18, 2023 03:41
6cd9aec
to
d13d16c
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
rachelkang
approved these changes
Jan 18, 2023
rmarinho
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit d2a0048. # Conflicts: # src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs
rmarinho
added a commit
that referenced
this pull request
Jan 20, 2023
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Look for this fix in 8.0.0-preview.1.7762!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-shell
Shell Navigation, Routes, Tabs, Flyout
area-controls-toolbar
ToolBar
fixed-in-8.0.0-preview.1.7762
Look for this fix in 8.0.0-preview.1.7762!
platform/iOS 🍎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With MAUI we moved the code for processing
Toolbar
logic up into the xplat layer by way of an xplatToolbar
control. This allowed us to consolidate the toolbar logic that was copy and pasted across all platforms and between shell and non-shell. On iOS the shell toolbar management is handled byShellPageToolbarTracker
which gets instantiated for every single page. The code inside that tracker needs to ignore anytoolbar
updates if it's not the currently visible page.iOS is also a little bit tricky to wire up with regards to timing the back button title text. The BackButton text is based on the
UIViewController.NavigationItem
of the previous page so we have to pull theBackButtonBehavior
off the incoming page and set it on theNavItem
of the previous page before the current page is visible.NavigationPage
gets around this by making it so the user has to setNavigationPage.BackButtonTitle
on the previous page.NavigationPage
basically replicates howiOS
propagates back button text where asShell
lets you set the back button text on the currently visible page.Issues Fixed
Fixes (but reverted) #10945
Fixes (but reverted) #11691
Fixes (but reverted) #9269
Fixes (but reverted) #9842
Fixes (but reverted) #9687