Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Android SearchBar keyboard issue relating to TextTransform #11981

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Address Android SearchBar keyboard issue relating to TextTransform #11981

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2062015
Minimal fix for when TextTransform isn't set
rachelkang Dec 8, 2022
0bd8afa
Merge branch 'main' into fix-10683
rachelkang Jan 3, 2023
3de1da9
Only set query if it's new (pair-program with EZ)
rachelkang Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Controls/src/Core/Platform/Android/Extensions/SearchViewExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Android.Widget;
using Microsoft.Maui.Controls.Internals;
using Microsoft.Maui.Controls.Internals;
using SearchView = AndroidX.AppCompat.Widget.SearchView;

namespace Microsoft.Maui.Controls.Platform
Expand All @@ -8,7 +7,11 @@ public static class SearchViewExtensions
{
public static void UpdateText(this SearchView searchView, InputView inputView)
{
searchView.SetQuery(TextTransformUtilites.GetTransformedText(inputView.Text, inputView.TextTransform), false);
var oldQuery = searchView.Query ?? string.Empty;
var newQuery = TextTransformUtilites.GetTransformedText(inputView.Text, inputView.TextTransform);

if (oldQuery != newQuery)
searchView.SetQuery(newQuery, false);
}
}
}
}