[iOS] Fix SearchBar focus issues #11698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
PureWeen
requested changes
Nov 28, 2022
There was a problem hiding this comment.
What do you think about my comment here?
#11542 (comment)
What if we if we fixed the "UnFocus" API so users could control if they want to open or close the keyboard?
Do you mind to move the logic to ViewHandler and check always the PlatformView status? |
Added Device Test, could you review it again? |
PureWeen
requested changes
Mar 17, 2023
src/Core/tests/DeviceTests/Handlers/SearchBar/SearchBarHandlerTests.iOS.cs
Show resolved
Hide resolved
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
PureWeen
approved these changes
Mar 20, 2023
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix SearchBar focus issues on iOS/Catalyst.
To test/validate the changes, launch the .NET MAUI Gallery and navigate to the SearchBar sample. Tap on the Focus SearchBar. A dialog must appear.
Issues Fixed
Fixes #11542