Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coredistools #370

Merged
merged 41 commits into from
Jan 3, 2024
Merged

Commits on Dec 21, 2023

  1. Update coredistools from LLVM 13.0.1 to 16.0.1

    1. LLVM doesn't release a full set of binary drops, so we need to
    build llvm-tblgen on some platforms, namely Mac.
    2. Build using standard CBL-Mariner Docker containers (used by
    dotnet/runtime as well). This also converts linux-x64 builds to be
    container-based cross builds.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    679a472 View commit details
    Browse the repository at this point in the history
  2. Update documentation

    Also, fix one compilation bug to build coredistools.cpp
    with LLVM 16.0.1.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0cff1f3 View commit details
    Browse the repository at this point in the history
  3. Fix macOS build

    Build llvm-tblgen from source on Mac
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    8e59b24 View commit details
    Browse the repository at this point in the history
  4. Minor build fixes for CBL-Mariner

    It still doesn't build correctly.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6d78ba6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    563c7db View commit details
    Browse the repository at this point in the history
  6. More diagnostic output

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d315458 View commit details
    Browse the repository at this point in the history
  7. Try again

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d0959db View commit details
    Browse the repository at this point in the history
  8. Try again

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    2efca46 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fea8d48 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5a00612 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e092482 View commit details
    Browse the repository at this point in the history
  12. Support non-CBL-Mariner builds

    Add options to scripts for non-CBL-Mariner builds.
    
    Revert coredistools.yml to building using non-CBL-Mariner (the
    CBL-Mariner logic is commented out). This means bringing back
    the native (non-cross) linux-x64 build.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6447421 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7846935 View commit details
    Browse the repository at this point in the history
  14. Use clang-9 on cross-build containers

    This wasn't done before, so it's no clear why it's needed now.
    
    Also, it seems like the built llvm-tblgen isn't working.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    188d60b View commit details
    Browse the repository at this point in the history
  15. For non-Mariner, use ubuntu-18.04 build pool

    Otherwise, we end up with clang-14 library dependencies in tblgen
    that don't run on our arm cross-compiler Docker images.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f1e128c View commit details
    Browse the repository at this point in the history
  16. AzDO pipelines no longer have ubuntu-18.04. Try ubuntu-20.04

    20.04 has clang 10, not clang 9.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    652a7aa View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e839237 View commit details
    Browse the repository at this point in the history
  18. Try llvmorg-16.0.6

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    36f400c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b685fdd View commit details
    Browse the repository at this point in the history
  20. More build fixes

    1. Disable annoying warning message
    2. Set proper CMAKE linker flags for library creation
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    bfc9ca8 View commit details
    Browse the repository at this point in the history
  21. Install runtime dependency of llvm-tblgen

    Use `tdnf install -y ncurses-compat` to install libtinfo.so.5
    dependency of llvm-tblgen.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    7ed048a View commit details
    Browse the repository at this point in the history
  22. Try using sudo

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0a06a1c View commit details
    Browse the repository at this point in the history
  23. Update cmake linker flags again

    Even if we're building a shared library, we still need to set the
    cmake EXE linker flags since cmake uses it during its testing phase.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0347ce6 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    13f613f View commit details
    Browse the repository at this point in the history
  25. Bump coredistools version from 1.1.0 to 1.2.0

    To use this in dotnet/runtime, after the package is published,
    `MicrosoftNETCoreCoreDisToolsVersion` in eng/Versions.props needs
    to be updated.
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4dfebad View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    e915089 View commit details
    Browse the repository at this point in the history
  27. Fix build

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    78556fc View commit details
    Browse the repository at this point in the history
  28. Fix build warning

    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1d3432a View commit details
    Browse the repository at this point in the history
  29. More fixes

    Output more diagnostics on Linux build-coredistools build
    
    Update documentation for building Linux
    BruceForstall committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    13316c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Fix task display name for "matrix" Linux build

    The matrix appends the architecture to the displayName automatically.
    
    Remove some debugging output.
    BruceForstall committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    3f0865a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e67a98e View commit details
    Browse the repository at this point in the history
  3. Bump up timeout

    In desperation
    BruceForstall committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    72f4188 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e093dc1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    46f7d89 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Various updates

    1. Update header file to have type definitions for all DLL exported
    functions.
    2. Remove unnecessary x86 instruction prefix handling (it was
    working around a bug that is apparently fixed).
    3. Remove coredistools special handling of movw/movt. Instead, add
    a hopefully more general mechanism where cordistools will optionally
    first call a "munger" function on constants. This callback in the
    superpmi NearDiffer for arm32 will decode the movw/movt and treat
    the constructed constant as being generated by one instruction.
    This can also be used by arm64 mov/movk/movk/movk, although we currently
    don't have a need for that.
    BruceForstall committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    0475ccd View commit details
    Browse the repository at this point in the history
  2. Change to version 1.3.0

    BruceForstall committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    15485b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Update version

    BruceForstall committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a546297 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Bump version to 1.4.0

    BruceForstall committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d9b0b34 View commit details
    Browse the repository at this point in the history
  2. Restore x86 special prefix handling

    Looks like at least `lock` is still not treated as part of the instruction
    that follows it.
    BruceForstall committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3d37674 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e43879c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8c1031 View commit details
    Browse the repository at this point in the history