Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auto-recall for input prompts #3611

Merged
merged 13 commits into from
Aug 15, 2024

Conversation

jonsequitur
Copy link
Contributor

@jonsequitur jonsequitur commented Jul 24, 2024

This PR addresses #3323.

⁠I've also removed the RequestInput.ValueName property. It is no longer needed. It's a minor breaking change for people directly using the input request APIs, but has no effect on magic command usage.

Copy link
Member

@colombod colombod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me so far

@jonsequitur jonsequitur marked this pull request as ready for review August 14, 2024 15:40
@jonsequitur jonsequitur merged commit 0f1a937 into dotnet:main Aug 15, 2024
4 checks passed
@jonsequitur jonsequitur deleted the secret-management branch August 21, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants