Fix issue where custom datetime format strings result in binding failure #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix issue with always using UtcNow, even with $localDatetime. Add tests
jonsequitur
reviewed
Apr 3, 2024
src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/DynamicExpressionUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
approved these changes
Apr 4, 2024
Require $datetime and $localDatetime to have either a custom format, or the rfc/iso options
Just specifying $datetime or #localDatetime should result in a IncorrectDateTimeFormat binding failure
Fix error strings to include proper escaping for {{$localDatetime ...}} strings, this was being output with only single set of braces which is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix issue with always using UtcNow, even with $localDatetime.
Add tests