add support for clearing variables from HttpKernel #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenning
reviewed
Feb 26, 2024
colombod
approved these changes
Feb 27, 2024
|
|
||
| namespace Microsoft.DotNet.Interactive.Http; | ||
|
|
||
| public class ClearValues : KernelCommand |
There was a problem hiding this comment.
This seems generally useful. Any reason why this is not defined in the core Interactive assembly?
Currently the http editor does not (need to) directly reference the Interactive.Http assembly. Adding that reference may not be problematic - but still wanted to double check whether we can move this to the main assembly and avoid the additional dependency.
| @@ -58,6 +56,12 @@ public class HttpKernel : | |||
| RegisterForDisposal(_client); | |||
| } | |||
|
|
|||
| public Task HandleAsync(ClearValues command, KernelInvocationContext context) | |||
There was a problem hiding this comment.
Could we implement this using explicit interface implementation and avoid the public API similar to what we do for the other commands below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.