Add description field to kernelInfo #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| KernelInfo.Description = """ | ||
| This Kernel can compile and execute C# code and display the results. | ||
| The language is C# Scripting, a dialect of C# that is used for interactive programming. | ||
| """; |
There was a problem hiding this comment.
Is this displayed anywhere in the UI? Will we need to localize this description for users who are on other languages?
|
Should we add a description for the composite kernel created by the dotnet-interactive tool? |
|
The description are not displayed in any UI and I added already the description to the composite kernel in the extension and on js and html kernels too
|
shyamnamboodiripad
approved these changes
Jan 4, 2024
Ah I was referring to the composite kernel that is created in this method. Not super important though - we can always add it later. |
|
That composite kernel (like the one in the dotnet tool) doesn't do anything special besides routing, there is no need for custom description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr adds support for description text on
KernelInfo.The description property is forwarded to
ProxyKernelstoo.Removed unused code with mermaid extension.