Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade F# language version for 8.0 #3392

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

kojo12228
Copy link
Contributor

Also update another reference to C# language to 12 (the other one being amended in #3338).

Because the language version in compiler args is preview anyway, this doesn't matter too much (although it did surprise me that it was set to preview).

@jonsequitur
Copy link
Contributor

Thanks, @kojo12228! This is a good catch.

The change you made doesn't affect the actual language version but it affects the language version that these two kernels advertise. There's probably a way (such as a test) to better keep these in sync in the future.

It incidentally caused one of the contract tests to fail.

This value should probably not be in the constructor for CSharpLanguageInfo and FSharpLanguageInfo since it's very much a moving target. But for now I'll hand-edit the approval file which should unblock this PR, and I'll open an issue for that afterwards.

@jonsequitur jonsequitur enabled auto-merge (squash) December 22, 2023 18:42
@jonsequitur jonsequitur merged commit bc12bb7 into dotnet:main Dec 22, 2023
4 checks passed
@colombod colombod added the Area-F# Specific to F# label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-F# Specific to F#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants