#import bug #3292
Merged
#import bug #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
force-pushed
the
import_bug
branch
2 times, most recently
from
25f5ba5
to
83fac04
Compare
jonsequitur
reviewed
Nov 2, 2023
| @@ -110,7 +111,8 @@ public static TKernel UseImportMagicCommand<TKernel>(this TKernel kernel) | |||
|
|
|||
| public static async Task LoadAndRunInteractiveDocument( | |||
| this Kernel kernel, | |||
| FileInfo file) | |||
| FileInfo file, | |||
| KernelCommand parentCommand) | |||
There was a problem hiding this comment.
This should probably be optional. There won't always be a parent command for this method, e.g. in automation scenarios.
make import extension use current command as parent. remove code restore comparer make parameter optional change to api contract
jonsequitur
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #3286