Stop bubbling KernelCommandResult.Events from child commands
#3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
stop-bubbling-KernelCommandResult.Events-from-child-commands
branch
from
7a21035
to
62dd0a1
Compare
| { | ||
| if (!@event.Command.Equals(Command)) | ||
| { | ||
| if (!Command.ShouldResultIncludeEventsFrom(@event.Command)) |
There was a problem hiding this comment.
consider: Combine the conditions
shyamnamboodiripad
approved these changes
Sep 21, 2023
jonsequitur
force-pushed
the
stop-bubbling-KernelCommandResult.Events-from-child-commands
branch
2 times, most recently
from
0d62038
to
b165390
Compare
jonsequitur
force-pushed
the
stop-bubbling-KernelCommandResult.Events-from-child-commands
branch
from
33f5f61
to
4c2f069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.