Improve handling for http responses that are too slow and / or too large #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows code in an external repo that links in this source file to compile without errors.
src/Microsoft.DotNet.Interactive.HttpRequest/HttpRequestKernel.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Jun 23, 2023
jonsequitur
reviewed
Jun 26, 2023
src/Microsoft.DotNet.Interactive.HttpRequest.Tests/HttpRequestKernelTests.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Jun 26, 2023
src/Microsoft.DotNet.Interactive.HttpRequest/Formatting/HttpResponseFormattingExtensions.cs
Outdated
Show resolved
Hide resolved
…tml elements.Send leading display events with partial http responses when the actual http responses are either too slow or too large. These leading events are then used to drive progress display to improve end-user perceived perormance.
jonsequitur
approved these changes
Jun 26, 2023
colombod
added
the
Area-Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
HttpRequestKernelto send leadingDisplayEvents with partial information when the complete http response is too slow and / or too large. These leading events are then used to drive progress display to improve end-user perceived performance.