HTTP kernel cleanups and some unimplemented tests #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
http-kernel-improvements-2
branch
from
e292e65
to
ec9773d
Compare
shyamnamboodiripad
approved these changes
Jun 15, 2023
| RegisterForDisposal(_client); | ||
| } | ||
|
|
||
| public Uri? BaseAddress |
There was a problem hiding this comment.
Looks like the API compatibility test baseline needs to be updated for removal of this public API.
There was a problem hiding this comment.
There is also a public SetValue function below. Does it need to be part of the public API considering the same can be accomplished via a SendValue commands?
There was a problem hiding this comment.
That can be removed I suspect.
There was a problem hiding this comment.
if the gesture is like value sharing then yes, we should remove that.
jonsequitur
force-pushed
the
http-kernel-improvements-2
branch
from
ec9773d
to
20170ee
Compare
colombod
added
Area-Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
BaseAddressproperty fromHttpRequestKerneland adds some tests, some of which won't be able to pass until the HTTP parser is updated.