Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PocketLogger custom formatting code as a content file as part of the Microsoft.DotNet.Interactive.VisualStudio NuGet package #3010

Merged

Conversation

shyamnamboodiripad
Copy link
Contributor

This makes it possible for consumers of this package to utilize the same custom formatting for commands and events as the dotnet-interactive tool when logging these objects via PocketLogger.

Also includes changes to:

  1. Make the code in Format.CustomizeLogString.cs self-sufficient.
  2. Make it an error to construct DiagnosticsProduced with 0 diagnostics. This a follow up to the change in Remove DiagnosticLogEntryProduced event. #3003 that allows us to clean up a TODO in Format.CustomizeLogString.cs.

@shyamnamboodiripad shyamnamboodiripad merged commit 7389d03 into dotnet:main Jun 2, 2023
@shyamnamboodiripad shyamnamboodiripad deleted the include-customizations branch June 2, 2023 21:06
@colombod colombod added the Area-Build & Infrastructure Relating to this repo's build and infrastructure label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Infrastructure Relating to this repo's build and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants