Remove DiagnosticLogEntryProduced event. #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +69,7 @@ public KernelCommandAndEventReceiver(ReadCommandOrEvent readCommandOrEvent) | |||
| { | |||
| Log.Error(exception); | |||
|
|
|||
| return new CommandOrEvent(new DiagnosticLogEntryProduced(exception.Message, KernelCommand.None), true); | |||
| return new CommandOrEvent(new ErrorProduced(exception.Message, KernelCommand.None), isParseError: true); | |||
There was a problem hiding this comment.
I'm not entirely sure if using ErrorProduced for this is ok. I was not able to figure out another way to handle this (other than allowing the exception to propagate). Please let me know in case you think this is not ok.
shyamnamboodiripad
force-pushed
the
remove-diagnostic-log
branch
2 times, most recently
from
f1ba8fe
to
dbe258f
Compare
shyamnamboodiripad
force-pushed
the
remove-diagnostic-log
branch
from
dbe258f
to
2462048
Compare
|
Why deleting this? The original goal for this event was to be intercepted by the vscode extension and routed tot he diagnostics and logs outputs. |
Ah this was something that @jonsequitur and I had discussed. We already removed the |
colombod
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.