Make value kernel extensible #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| mimeType ??= (options.MimeType ?? PlainTextFormatter.MimeType); | ||
|
|
||
| var shouldDisplayValue = options.MimeType is { } displayMimeType; |
There was a problem hiding this comment.
nit: The displayMimeType variable is unused and can be dropped.
| } | ||
|
|
||
| return Task.CompletedTask; |
There was a problem hiding this comment.
Can the method be made sync or is this async because we think we may need it down the line?
| @@ -143,7 +143,7 @@ Task IKernelCommandHandler<SendValue>.HandleAsync(SendValue command, KernelInvoc | |||
| context.Fail(command, | |||
| message: "The --from-file option cannot be used in combination with a content submission."); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
minor: Remove blank line.
| string value, | ||
| string mimeType, | ||
| bool shouldDisplayValue, | ||
| KernelInvocationContext context) | ||
|
|
There was a problem hiding this comment.
minor: Consider removing blank line...
shyamnamboodiripad
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.