Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust resource namespace of resources to Microsoft.DotNet.Interactive for Microsoft.DotNet.Interactive.VisualStudio #2927

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

ocallesp
Copy link
Contributor

@ocallesp ocallesp commented Apr 20, 2023

During runtime, the Microsoft.DotNet.Interactive.VisualStudio project searches for string resources within the Microsoft.DotNet.Interactive namespace. This change aligns the resource namespace with the imported project that owns the resource, ensuring proper resource loading and usage.

BEFORE
image

AFTER
image

During runtime, the Microsoft.DotNet.Interactive.VisualStudio project searches
for string resources within the Microsoft.DotNet.Interactive namespace. This
change aligns the resource namespace with the imported project that owns the
resource, ensuring proper resource loading and usage.
@ocallesp ocallesp changed the title Adjust resource namespace to Microsoft.DotNet.Interactive Adjust resource namespace of resources to Microsoft.DotNet.Interactive for Microsoft.DotNet.Interactive.VisualStudio Apr 20, 2023
@ocallesp ocallesp marked this pull request as ready for review April 20, 2023 02:44
@ocallesp ocallesp enabled auto-merge April 20, 2023 02:44
@ocallesp ocallesp merged commit 3f30521 into dotnet:main Apr 20, 2023
@ocallesp ocallesp deleted the fix-resource-namespace-in-assembly branch April 20, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants