Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable localization #2897

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Enable localization #2897

merged 3 commits into from
Apr 17, 2023

Conversation

ocallesp
Copy link
Contributor

@ocallesp ocallesp commented Apr 7, 2023 •
edited
Loading

TODO: Pass localization culture to dotnet interactive

@ocalles
Localize dotnet interactive
94108db 
Use a consistent pattern to name variables
Use prefix:
Magics_          to refer to commands executed within Notebook
Cli_                  to refer to command line commands
@jonsequitur jonsequitur merged commit 95a4640 into dotnet:main Apr 17, 2023
@ocallesp ocallesp deleted the add-localization branch August 4, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

@brettfo brettfo Awaiting requested review from brettfo

@shyamnamboodiripad shyamnamboodiripad Awaiting requested review from shyamnamboodiripad

@colombod colombod Awaiting requested review from colombod

Assignees
No one assigned
Labels
Area-Localization and Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocallesp @colombod @jonsequitur @ocalles