Improve memory usage #2866
Merged
Improve memory usage #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
approved these changes
Mar 24, 2023
| //This fixes an issue where the performance of language services is degrading each time a new submission is run. | ||
| //Forces the creation of the Compilation object in the project of the previous submission | ||
| //If the compilation were not eagerly created, the entire solution would be compiled each | ||
| //time it is used to answer a language service question (ForkDocumentForLanguageServices). |
There was a problem hiding this comment.
Is this a tradeoff between memory and throughput?
In other words, does removing this code mean that intellisense will be slower because "entire solution would be compiled each time it is used to answer a language service question"? Or is it safe to remove this code because the underlying problem has been fixed in Roslyn, and it is no longer necessary to materialize the compilation each time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves memory behaviour for csharp kernel