Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve StdIoConnector #2807

Merged
merged 19 commits into from
Mar 14, 2023
Merged

Improve StdIoConnector #2807

merged 19 commits into from
Mar 14, 2023

Conversation

shyamnamboodiripad
Copy link
Contributor

Also fix some bugs in the RequestKernelInfo flow and add tests.

@shyamnamboodiripad
Remove implicit RequestKerenlInfo flow in ProxyKernel.
90b7dcf
@shyamnamboodiripad
Ensure that CreateProxyKernelAsync can create proxy to a remote compo…
d5c7c0f 
…site kernel with a specific name.
@shyamnamboodiripad
Update baseline for compatibility test.
102a36c
@shyamnamboodiripad
Avoid the need to sent RequestKernelInfo by remembering previously se…
ad47b91 
…en KernelInfos in StdIoKernelConnector.

Since KernelInfos are sent immideately after KernelReady this means we can avoid sending RequestKernelInfo entirely by default for the initial set of kernels.
@shyamnamboodiripad shyamnamboodiripad merged commit c9a7a76 into dotnet:main Mar 14, 2023
@shyamnamboodiripad shyamnamboodiripad deleted the improve-connector branch March 14, 2023 01:34
@shyamnamboodiripad shyamnamboodiripad mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colombod colombod colombod left review comments

@jonsequitur jonsequitur jonsequitur approved these changes

Assignees
No one assigned
Labels
Area-Messaging / scheduling / comms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyamnamboodiripad @colombod @jonsequitur