kernelinfo carries information on kernel type #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing ; fix test use isProxy fix test
jonsequitur
reviewed
Feb 10, 2023
| @@ -229,10 +229,12 @@ Microsoft.DotNet.Interactive | |||
| public System.Threading.Tasks.Task<Microsoft.DotNet.Interactive.Connection.ProxyKernel> ConnectProxyKernelOnDefaultConnectorAsync(System.String localName, System.Uri remoteKernelUri, System.String[] aliases = null) | |||
| public System.Void Dispose() | |||
| public class KernelInfo | |||
| .ctor(System.String localName, System.String[] aliases = null) | |||
| .ctor(System.String localName, System.String[] aliases = null, System.Boolean isProxy = False, System.Boolean isComposite = False) | |||
There was a problem hiding this comment.
Having two different constructors with slightly different arguments is a little confusing and probably pointless given all the setters on this class. Maybe we should remove both constructors and just have a default constructor?
There was a problem hiding this comment.
the other one is marked as deprecated, we should remove it remove it
jonsequitur
reviewed
Feb 10, 2023
| .ctor(System.String localName, System.String languageName, System.String languageVersion, System.String[] aliases) | ||
| public System.String[] Aliases { get; set;} | ||
| public System.String DisplayName { get; set;} | ||
| public System.Boolean IsComposite { get;} | ||
| public System.Boolean IsProxy { get;} |
There was a problem hiding this comment.
These should be mutable like the others... I think.
jonsequitur
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.