KernelCommandResult.KernelEvents
type change
#2699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to improving diagnostics, we decided to change
KernelCommandResult.KernelEvents
fromIObservable<KernelEvent>
toIReadOnlyList<KernelEvent>
, since this fits the common usage pattern much more closely.In practice, the observable returned by
KernelCommandResult.KernelEvents
is always fully populated by the time theCommandResult
is returned fromSendAsync
. Certain internal methods respond to the emitted events as they're produced but the external user of the API will never see them until the sequence is completed, which is why it was implemeted as aReplaySubject
.This change should make the API clearer and easier to use.