Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable completion documentation for C# #2638

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jonsequitur
Copy link
Contributor

@jonsequitur jonsequitur commented Jan 24, 2023

In many cases, completion documentation isn't used. It's a slightly hidden feature in VS Code and even when you know about it, you're not likely to read it for every completion item. A lazy evaluation or caching strategy can be used in the future to put this functionality back (#2637) but in the meantime, the performance improvement gained by removing it should benefit everyone.

@jonsequitur jonsequitur enabled auto-merge (rebase) January 24, 2023 03:11
FormatAndStyleAsPlainText(value, context);
return true;
}),
// // decimal should be displayed as plain text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this it taken out?

@jonsequitur jonsequitur merged commit dfce8b1 into dotnet:main Jan 24, 2023
@colombod colombod added the Area-C# Specific to C# label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-C# Specific to C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants