dispose of the host when receiving the quit command #2635
Conversation
| @@ -346,6 +344,13 @@ Command StdIO() | |||
| receiver, | |||
| startupOptions.KernelHost); | |||
|
|
|||
| kernel.UseQuitCommand(() => | |||
| { | |||
| host.Dispose(); | |||
There was a problem hiding this comment.
Ultimately the fix was to add host.Dispose() to the quit handler.
This fixes issues with the backing process not closing appropriately.
brettfo
force-pushed
the
quit-command-exit-process
branch
from
9277147
to
d3630d4
Compare
| { | ||
| var http = new HttpRequestKernelExtension(); | ||
| await http.OnLoadAsync(kernel); | ||
| if (startupOptions.Preview) |
There was a problem hiding this comment.
Question unrelated to this PR: How are people supposed to enable this? Why not publish as an extension and let people try it out via a NuGet package?
There was a problem hiding this comment.
right now this is enabled if you use vscode insiders or via --preview option on the command line
|
Although #2527 is marked resolved by this issue, I am still getting multiple runaway dotnet processes when closing VS Code Insiders after using Polygot Notebooks. macOS 13.2.1 M1 MacBook Air edits: autocorrect |
|
And this is with the latest release from the 15th of March? Can you share the vscode and extension and tool versions? |
|
@watersb What version of the extension are you using, and do you have any VS Code or Polyglot Notebooks extension updates pending? |
|
I am sorry at the lousy state of my terse bug report.This was, I believe, the March 25 version of VSC Insider channel.But it's hardly a clean installation; $HOME/.vscode is about 2.5 GB. And I also had the dotNET SDK installed via Homebrew. I don't know if that is relevant, but it's impeding my ability to reason about where to look.I would like to try with a clean install of VS Code and report back. I'm backing up this machine at the moment, before a clean re-install of macOS -- but I won't take that step until I've at least been able to answer basic questions about the configuration that's currently experiencing this consistent bug behavior.Thanks very much for your work on this, I hope to have better info tomorrow.----On Mar 22, 2023, at 11:03 AM, Jon Sequeira ***@***.***> wrote:
@watersb What version of the extension are you using, and do you have any VS Code or Polyglot Notebooks extension updates pending?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This fixes issues with the backing process not closing appropriately. Verified on both Windows and Mac.
Fixes #2527.