text/plain+summary formatter
#2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of hard-coding "vscode" as the TargetKernelName
jonsequitur
force-pushed
the
formatting-improvements-2023-01-12
branch
from
178288f
to
83b80b1
Compare
brettfo
reviewed
Jan 18, 2023
...tion/SerializationTests.Command_contract_has_not_been_broken.approved.RequestValueInfos.json
Outdated
Show resolved
Hide resolved
brettfo
reviewed
Jan 18, 2023
...ction/SerializationTests.Event_contract_has_not_been_broken.approved.ValueInfosProduced.json
Outdated
Show resolved
Hide resolved
brettfo
reviewed
Jan 18, 2023
brettfo
reviewed
Jan 18, 2023
| return LocalName; | ||
| } | ||
|
|
||
| return $"{LocalName} - {LanguageName}"; |
There was a problem hiding this comment.
The local name is always displayed in VS Code, so this will lead to the C# display name being csharp - csharp - C# Script
There was a problem hiding this comment.
Doesn't seem to be the case:
brettfo
reviewed
Jan 18, 2023
brettfo
reviewed
Jan 18, 2023
brettfo
approved these changes
Jan 18, 2023
colombod
added
the
Area-Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a
text/plain+summaryformatter, to be used in the variable explorer and similar places where more concise plain text output is desirable.This also reduces the indentation for multi-line plaintext output formatting.