Add environment variables to enable service logging in the MSSQL and Kusto kernels #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
commented
Jan 10, 2023
| @@ -35,7 +35,15 @@ public async Task<Kernel> CreateKernelAsync(string kernelName) | |||
|
|
|||
| var connectionDetails = await BuildConnectionDetailsAsync(); | |||
|
|
|||
| var client = new ToolsServiceClient(PathToService); | |||
| var serviceArgs = $"--parent-pid {Environment.ProcessId}"; | |||
There was a problem hiding this comment.
This parent-pid argument here is the ID of the current process, so that we can close the service process after the parent process has exited. This was added to the SQL kernel a while ago, but was missed in the Kusto kernel.
jonsequitur
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't have any way to collect logs from the SQL and Kusto service processes if there are any issues. This change adds an environment variable to provide a log file to dump traces to for those services. Tracing is only enabled if the environment variables are set.