Add environment variables to enable service logging in the MSSQL and …

…Kusto kernels (#2608) * Add environment variable for enabling logging for SQL and Kusto kernels. * Use file instead of folder * Fix arguments * Use better string building logic
dotnet · Jan 10, 2023 · 02e9bb6 · 02e9bb6
1 parent 45db0c6
commit 02e9bb6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/Microsoft.DotNet.Interactive.Kql/KqlKernelConnector.cs b/src/Microsoft.DotNet.Interactive.Kql/KqlKernelConnector.cs
@@ -35,7 +35,15 @@ public async Task<Kernel> CreateKernelAsync(string kernelName)
 
         var connectionDetails = await BuildConnectionDetailsAsync();
 
-        var client = new ToolsServiceClient(PathToService);
+        var serviceArgs = $"--parent-pid {Environment.ProcessId}";
+        var logFile = Environment.GetEnvironmentVariable("DOTNET_KUSTOSERVICE_LOGFILE");
+        if (!string.IsNullOrWhiteSpace(logFile))
+        {
+            var logArgs = $" --log-file \"{logFile}\" --tracing-level Verbose";
+            serviceArgs += logArgs;
+        }
+
+        var client = new ToolsServiceClient(PathToService, serviceArgs);
 
         var kernel = new MsKqlKernel(
                 $"kql-{kernelName}",

diff --git a/src/Microsoft.DotNet.Interactive.SqlServer/MsSqlKernelConnector.cs b/src/Microsoft.DotNet.Interactive.SqlServer/MsSqlKernelConnector.cs
@@ -28,7 +28,15 @@ public async Task<Kernel> CreateKernelAsync(string kernelName)
             throw new InvalidOperationException($"{nameof(PathToService)} cannot be null or whitespace.");
         }
 
-        var client = new ToolsServiceClient(PathToService, $"--parent-pid {Environment.ProcessId}");
+        var serviceArgs = $"--parent-pid {Environment.ProcessId}";
+        var logFile = Environment.GetEnvironmentVariable("DOTNET_SQLTOOLSSERVICE_LOGFILE");
+        if (!string.IsNullOrWhiteSpace(logFile))
+        {
+            var logArgs = $" --log-file \"{logFile}\" --tracing-level Verbose";
+            serviceArgs += logArgs;
+        }
+
+        var client = new ToolsServiceClient(PathToService, serviceArgs);
 
         var kernel = new MsSqlKernel(
                 $"sql-{kernelName}",