Disable SCM queries for build #17157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
approved these changes
Aug 9, 2023
| @@ -4,6 +4,7 @@ | |||
| <ImportNetSdkFromRepoToolset>false</ImportNetSdkFromRepoToolset> | |||
| <_SuppressSdkImports>true</_SuppressSdkImports> | |||
| <Configuration Condition="$(Configuration) == ''">Release</Configuration> | |||
| <EnableSourceControlManagerQueries>false</EnableSourceControlManagerQueries> | |||
There was a problem hiding this comment.
Your description made me think this was only needed for the package-source-build project? Is there a reason to set it here versus the package-source-build project?
There was a problem hiding this comment.
Yes, it's only needed for package-source-build. But given the intent of the property, it seemed relevant to apply it to all projects in this context to avoid potential issues in the future.
There was a problem hiding this comment.
it seemed relevant to apply it to all projects in this context to avoid potential issues in the future.
That makes sense but keep in mind it won't flow into the project repo build the way it is set so it really has limited value here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SB smoke tests are failing due to the
.versionfile in the SB artifacts tarball not having the correct content. It doesn't contain the repo commit but does have the version. The MSBuild property that's used to input the repo commit is$(RepositoryCommit). Looking at the binlog shows that this property is not set for thepackage-source-buildproject.This is caused by source-link being bundled with the SDK in dotnet/sdk#31632. Because of that
EnableSourceControlManagerQueriesgets defaulted totrue. And becauseEnableSourceControlManagerQueriesistrue, it causesRepositoryCommitto not be set.This is fixed by explicitly disabling
EnableSourceControlManagerQueries.Fixes dotnet/source-build#3426