Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default build configuration #42418

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix default build configuration #42418

merged 1 commit into from
Sep 3, 2024

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Sep 3, 2024 •
edited by github-actions bot
Loading

@tdykstra tdykstra requested a review from a team as a code owner September 3, 2024 01:00
@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 3, 2024
@dotnet-policy-service dotnet-policy-service bot added okr-health okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Sep 3, 2024
BillWagner
BillWagner approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdykstra

This LGTM. I'll :shipit:

@BillWagner BillWagner merged commit 05f3996 into main Sep 3, 2024
12 checks passed
@BillWagner BillWagner deleted the tdykstra-patch-1 branch September 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-health okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.

Default publish configuration may need updating in docs\core\tutorials\publishing-with-visual-studio-code.md
3 participants
@tdykstra @BillWagner @dotnet-bot