Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property to add non-file URL resolver support #42387

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Add property to add non-file URL resolver support #42387

merged 3 commits into from
Sep 3, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 29, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested review from adegeo and a team as code owners August 29, 2024 23:59
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 29, 2024
BillWagner
BillWagner approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 1d7ffd1 into dotnet:main Sep 3, 2024
8 checks passed
@gewarren gewarren deleted the url-resolver branch September 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Document making non-file URL support optional in XmlUrlResolver
3 participants
@gewarren @BillWagner @dotnet-bot