Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance of Azure Identity library sample apps #42368

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Maintenance of Azure Identity library sample apps #42368

merged 1 commit into from
Aug 29, 2024

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Aug 28, 2024 •
edited by github-actions bot
Loading

Summary of changes

  • Migrate to central package management. We want all samples to use the same Azure.Identity version.
  • Remove unused broker dependency from username/password project
  • Move additional auth samples to authentication folder

Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/authentication/additional-methods.md docs/azure/sdk/authentication/additional-methods

@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 28, 2024
@scottaddie scottaddie marked this pull request as ready for review August 28, 2024 18:57
BillWagner
BillWagner approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit 501284a into main Aug 29, 2024
10 checks passed
@BillWagner BillWagner deleted the scottaddie/additional-auth-methods branch August 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@alexwolfmsft alexwolfmsft alexwolfmsft approved these changes

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@CamSoper CamSoper Awaiting requested review from CamSoper CamSoper is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees
No one assigned
Labels
dotnet-azure/svc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@scottaddie @BillWagner @alexwolfmsft @dotnet-bot